Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore volume in use error during compose down test #59

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

monirul
Copy link
Contributor

@monirul monirul commented Apr 11, 2023

Issue #, if available:
261
Description of changes:
Currently, compose down command sometimes fails due to volume in use by the container.
example:

time="2023-04-11T16:02:03Z" level=warning msg="error while executing [/usr/local/bin/nerdctl volume rm -f finch-compose4020426052_compose_data_volume]: \"time=\\\"2023-04-11T16:02:03Z\\\" level=fatal msg=\\\"volume \\\\\\\"finch-compose4020426052_compose_data_volume\\\\\\\" is in use\\\"\\n\": exit status 1"

Testing done:
Yes

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@monirul monirul requested review from pendo324 and KevinLiAWS April 11, 2023 21:23
@monirul monirul force-pushed the monirul/fix-volume-error branch from fb60994 to 9d9476f Compare April 11, 2023 21:27
@monirul monirul merged commit 33e8d75 into runfinch:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants