feat: add e2e tests for resource and user flags #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnqiPang
force-pushed
the
anqipang/test-run-resource
branch
from
d65acdc to
e29070b
Compare
Signed-off-by: Anqi Pang <[email protected]>
AnqiPang
force-pushed
the
anqipang/test-run-resource
branch
from
e29070b to
bab676b
Compare
AnqiPang
changed the title
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
AnqiPang
force-pushed
the
anqipang/test-run-resource
branch
from
bfdb54e to
cc915bc
Compare
There was a problem hiding this comment.
LGTM overall, please also create a follow-up to only run --no-trunc and --no-stream tests for cgroupv2 hosts (#5 (comment)). We can probably also move type CGMode int from run.go to tests.go as multiple test options will reference it.
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
I will double check whether |
Signed-off-by: Anqi Pang <[email protected]>
davidhsingyuchen
approved these changes
Dec 9, 2022
mharwani
pushed a commit
that referenced
this pull request
Dec 15, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.0](v0.1.1...v0.2.0) (2022-12-13) ### Features * add e2e tests for resource and user flags ([#5](#5)) ([1d5ec0d](1d5ec0d)) ### Build System or External Dependencies * **deps:** bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 ([#12](#12)) ([a676453](a676453)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.