refactor: specify timeout for HTTP calls in run -p/--publish test
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the title should describe the actual things you are fixing. |
vsiravar
force-pushed
the
vsiravar/publish-flag-pr-fix
branch
from
d00c961 to
397a784
Compare
vsiravar
changed the title
1 task
Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
force-pushed
the
vsiravar/publish-flag-pr-fix
branch
from
397a784 to
5ade2ca
Compare
vsiravar
changed the title
davidhsingyuchen
changed the title
run -p/--publish test
davidhsingyuchen
approved these changes
Feb 28, 2023
davidhsingyuchen
changed the title
run -p/--publish testrun -p/--publish test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Code review fix for #39
Testing done:
Yes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.