feat: add additional tests for env vars #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estesp
changed the title
ningziwen
approved these changes
Jan 30, 2023
|
I think this should be "feat" although the relevant CLI change can be "fix". Common-test repo has a slightly different version rule. Adding new tests should bump minor version. |
estesp
changed the title
Sounds good; I've updated the PR |
Signed-off-by: Phil Estes <[email protected]>
ningziwen
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2023-02-01) ### Features * add additional tests for env vars ([#26](#26)) ([d3b48e2](d3b48e2)) ### Build System or External Dependencies * **deps:** bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.8.0 ([#27](#27)) ([723b70e](723b70e)) * **deps:** bump github.com/onsi/gomega from 1.24.2 to 1.26.0 ([#24](#24)) ([33e2c83](33e2c83)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper tests for the changes to handling of
-e/--envand--env-filein runfinch/finch#158Signed-off-by: Phil Estes [email protected]
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.