feat: add option features to skip tests #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds features map to option for skipping unsupported tests based on supported features. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-option-features-to-skip-tests
branch
from
f3f1801 to
2c57bf1
Compare
pendo324
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #209
finch-core currently uses limactl shell + nerdctl to test macOS VM image and container runtime archive updates. Currently there is no simple solution for passing through environment variables which is required for compose build test suite. This is currently blocking common-tests updates in finch-core.
Description of changes:
This change adds features map to option for skipping unsupported tests based on supported features.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.