Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add longform bool flag coverage for e2e testing #191

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

coderbirju
Copy link
Contributor

Issue #, if available:

Description of changes:

This change adds tests that use long form boolean flags with true/false values to verify that the finch command parses and runs the command correctly.

Testing done:
Verified that the tests pass by running test-e2e make target

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju changed the title chore: [WIP] add longform bool flag coverage for e2e testing chore: add longform bool flag coverage for e2e testing Nov 15, 2024
tests/exec.go Outdated Show resolved Hide resolved
tests/start.go Outdated Show resolved Hide resolved
tests/start.go Show resolved Hide resolved
tests/exec.go Show resolved Hide resolved
Copy link

@sondavidb sondavidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@coderbirju coderbirju merged commit 4f09830 into runfinch:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants