Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: runfinch/common-tests
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.16
Choose a base ref
...
head repository: runfinch/common-tests
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.7.17
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on Mar 25, 2024

  1. fix: track localImages in a new map to enable proper cleanup (#133)

    Issue #, if available: See
    https://github.com/runfinch/finch/actions/runs/8424406162/job/23068204038?pr=825#step:10:5839
    ```
      time="2024-03-25T17:50:43Z" level=info msg="trying next host" error="failed to do request: Head \"http://localhost:51261/v2/docker/library/alpine/manifests/latest\": dial tcp [::1]:51261: connect: connection refused" host="localhost:51261"
      time="2024-03-25T17:50:43Z" level=error msg="server \"localhost:51261\" does not seem to support HTTPS" error="failed to resolve reference \"localhost:51261/docker/library/alpine:latest\": failed to do request: Head \"http://localhost:51261/v2/docker/library/alpine/manifests/latest\": dial tcp [::1]:51261: connect: connection refused"
      time="2024-03-25T17:50:43Z" level=info msg="Hint: you may want to try --insecure-registry to allow plain HTTP (if you are in a trusted network)"
      time="2024-03-25T17:50:43Z" level=fatal msg="failed to resolve reference \"localhost:51261/docker/library/alpine:latest\": failed to do request: Head \"http://localhost:51261/v2/docker/library/alpine/manifests/latest\": dial tcp [::1]:51261: connect: connection refused"
      time="2024-03-25T17:50:43Z" level=fatal msg="exit status 1"
    ```
    
    This error occurs here because the localImages map already has the
    "local" entries, even though `CleanupLocalRegistry` was run (and on top
    of that, the VM's disk was completely reset, including the local
    registry container. This is an edge case that occurs here because the
    `tests` package is imported once, and the global state of the
    `localImages` map is preserved.
    
    *Description of changes:*
    - Instead of using one map and overriding its entries, store the local
    entries in a new map so that `CleanupLocalRegistry` can reset it, and a
    subsequent `SetupLocalRegistry` can repopulate it without issue
    
    *Testing done:*
    - Tested after running Setup -> Clean -> Setup (by running the exact
    same failing e2e test locally), and it now works
    
    
    - [x] I've reviewed the guidance in CONTRIBUTING.md
    
    
    #### License Acceptance
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    
    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    pendo324 authored Mar 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c8a5e72 View commit details
  2. build(deps): Bump github.com/onsi/ginkgo/v2 from 2.17.0 to 2.17.1 (#132)

    Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from
    2.17.0 to 2.17.1.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo/v2's
    releases</a>.</em></p>
    <blockquote>
    <h2>v2.17.1</h2>
    <h2>2.17.1</h2>
    <h3>Fixes</h3>
    <ul>
    <li>If the user sets --seed=0, make sure all parallel nodes get the same
    seed [af0330d]</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a
    href="https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md">github.com/onsi/ginkgo/v2's
    changelog</a>.</em></p>
    <blockquote>
    <h2>2.17.1</h2>
    <h3>Fixes</h3>
    <ul>
    <li>If the user sets --seed=0, make sure all parallel nodes get the same
    seed [af0330d]</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/onsi/ginkgo/commit/92423385b96b8be0ac6c4686ff305f30f885e59e"><code>9242338</code></a>
    v2.17.1</li>
    <li><a
    href="https://github.com/onsi/ginkgo/commit/af0330d31fa540b51756c14daf6b1c55515a379c"><code>af0330d</code></a>
    If the user sets --seed=0, make sure all parallel nodes get the same
    seed</li>
    <li>See full diff in <a
    href="https://github.com/onsi/ginkgo/compare/v2.17.0...v2.17.1">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/onsi/ginkgo/v2&package-manager=go_modules&previous-version=2.17.0&new-version=2.17.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Mar 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c55e33b View commit details
  3. chore(main): release 0.7.17 (#134)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [0.7.17](v0.7.16...v0.7.17)
    (2024-03-25)
    
    
    ### Build System or External Dependencies
    
    * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.17.0 to 2.17.1
    ([#132](#132))
    ([c55e33b](c55e33b))
    
    
    ### Bug Fixes
    
    * track localImages in a new map to enable proper cleanup
    ([#133](#133))
    ([c8a5e72](c8a5e72))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Mar 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    e4f2260 View commit details
Loading