Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: increase acceptable time deviation for stop tests with -t (#81)
Issue #, if available: *Description of changes:* Increase acceptable time deviation from 500ms -> 750ms. This test checks to see that the `-t/--time` flag waits a certain amount of time (in the test's case, 1s) before sending the stop signal and killing the container. We're currently seeing fairly frequent failures of this test in `finch-core`, with stop times very slightly outside of the acceptable range: - [1.529945577s](https://github.com/runfinch/finch-core/actions/runs/6228992440/job/16933345175?pr=159#step:7:13397) - [1.528963170s](https://github.com/runfinch/finch-core/actions/runs/6228992440/job/16933345175?pr=159#step:7:13397) - [1.502652516s](https://github.com/runfinch/finch-core/actions/runs/6228992440/job/16933345175?pr=159#step:7:13314) - etc... This exact timing isn't super critical, and these test failures are kind of painful for merging PRs, so increasing the allowable deviation makes sense here. *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Sam Berning <[email protected]>
- Loading branch information