Skip to content

Commit

Permalink
fix: adds --all to the volume prune command to prune named volumes (#86)
Browse files Browse the repository at this point in the history
see
containerd/nerdctl@0844a51

Issue #, if available:

*Description of changes:*

CI was failing in finch and finch-core due to a named volume not getting
cleaned up after bumping nerdctl to v1.6.0. turns out there was a change
in behavior for the `volume prune` command.

*Testing done:*

Ran common-tests with @vsiravar and the volume tests succeeded

- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Sam Berning <[email protected]>
  • Loading branch information
sam-berning authored Sep 21, 2023
1 parent 011c2e3 commit 4973e9f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions command/remove.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package command

import (
"github.com/onsi/ginkgo/v2"

"github.com/runfinch/common-tests/option"
)

Expand Down Expand Up @@ -42,7 +41,7 @@ func RemoveVolumes(o *option.Option) {
ginkgo.GinkgoWriter.Println("No volumes to be removed")
return
}
Run(o, "volume", "prune", "--force")
Run(o, "volume", "prune", "--force", "--all")
}

// RemoveImages removes all container images in the testing environment specified by o.
Expand Down

0 comments on commit 4973e9f

Please sign in to comment.