Fix #352 node attribute expansion not working for ssh-xyz attributes #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support `_-:` chars in output format key names
gschueler
force-pushed
the
issue/352-rd-nodes-list-outformat-doesn-t-support-dashes
branch
from
b89a08c to
78af0f8
Compare
gschueler
deleted the
issue/352-rd-nodes-list-outformat-doesn-t-support-dashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_-chars in output format key namesfixes #352
:char as well, however it broke a testcase like%id:%token. I think adding:makes sense in the node output case because node attributes do use:char, but we need to add another syntax that would allow the%id:%tokento still work, something like${id}:${token}or%{id}:%{token}with a suffix in the syntax. I am not addressing that in this bug fix, it will have to be a future enhancement.