support for execution metrics API #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
…o dev/execution_query_metrics # Conflicts: # rd-api-client/src/main/java/org/rundeck/client/api/RundeckApi.java
|
CLI Options for rundeck/rundeck#4317 |
|
I see the "executions metrics" command outputs only raw json or xml. A future enhancement would be to behave like the other rd commands that output a textual view of the response, so it is useful to eyeball it on the commandline, but allow using |
|
The default of the command is indeed to output a readable text version of the response, unless either –json or –xml arguments are specified, in which case the output raw json or xml respectively. I didn’t notice the RD_FORMAT env var so setting it will have no effect.
From: Greg Schueler <[email protected]>
Reply-To: rundeck/rundeck-cli <[email protected]>
Date: Wednesday, January 16, 2019 at 16:28
To: rundeck/rundeck-cli <[email protected]>
Cc: Alberto Hormazabal <[email protected]>, Author <[email protected]>
Subject: Re: [rundeck/rundeck-cli] support for execution metrics API (#210)
I see the "executions metrics" command outputs only raw json or xml. A future enhancement would be to behave like the other rd commands that output a textual view of the response, so it is useful to eyeball it on the commandline, but allow using RD_FORMAT=json env var to specify a formatted output.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#210 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALArvY3-zqCdYw4PSa88wcvT8LPcB9ylks5vD31HgaJpZM4ZXdTC>.
|
|
@ahormazabal great, i misread the first options check and thought it was requiring |
add -%/--format output remove --json, defer to RD_FORMAT allow RD_FORMAT=xml or --xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new command 'rd executions metrics help'