Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Version Selector to Navbar #1603

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Adds a Version Selector to Navbar #1603

merged 3 commits into from
Dec 17, 2024

Conversation

fdevans
Copy link
Contributor

@fdevans fdevans commented Dec 12, 2024

We might want to get some styling improvements from @smartinellibenedetti but this implements a drop down in the Navbar for previous versions with "Cloud" going to the latest docs.

@fdevans fdevans added this to the 5.9.0 milestone Dec 12, 2024
@fdevans fdevans requested review from jsboak and removed request for ChuckCrawford December 17, 2024 18:18
@jsboak
Copy link
Contributor

jsboak commented Dec 17, 2024

This is great. Only ask is whether the dropdown can be "backported" to the prior versions so that users can easily navigate from one version to another. The way it's implemented now will only make the dropdown available from version 5.8.0 onwards

@fdevans
Copy link
Contributor Author

fdevans commented Dec 17, 2024

No. There isn't an easy way to backport this as it relies on the latest vuepress template theme

Copy link
Contributor

@jsboak jsboak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition!

@fdevans fdevans merged commit 45d91e0 into 4.0.x Dec 17, 2024
1 check passed
@fdevans fdevans deleted the version-picker branch December 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants