Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful log output to aid with troulbeshooting of vault login. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienjoldersma-rakuten
Copy link

@damienjoldersma-rakuten damienjoldersma-rakuten commented Mar 11, 2024

I had some trouble with setting up Vault and Rundeck integration - I was receiving a NullPointerException in the logs with no other information to help me understand the problem of my misconfiguration.

This pull request will help others in troulbeshooting misconfiguration or other Vault / Rundeck integration problems. Basically it changes the plugin to not ignore and not to just swallow login exceptions.

Here are some example of the exception output that was being hidden, which were essential in understanding to resolve the misconfiguration:

[2024-03-11T02:07:26,527] WARN  vault-storage [qtp689905739-81] - Error logging into Vault: Encountered error while authenticating with approle: Vault responded with HTTP status code: 400
Response body: {"errors":["invalid role ID"]}
[2024-03-11T02:12:48,291] WARN  vault-storage [pool-12-thread-1] - Error logging into Vault: Encountered error while authenticating with approle: Vault responded with HTTP status code: 400
Response body: {"errors":["invalid secret id"]}

…so, do not ignore and do not just swallow login exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant