Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN-506: Appending files instead of overriding #83

Merged
merged 4 commits into from
Nov 18, 2021
Merged

RUN-506: Appending files instead of overriding #83

merged 4 commits into from
Nov 18, 2021

Conversation

L2JE
Copy link
Contributor

@L2JE L2JE commented Nov 15, 2021 •
edited
Loading

Fixes: https://github.com/rundeckpro/rundeckpro/issues/2147

winrm-filecopier.py now deletes the target file if it already exists on the remote server on user's behalf.

image

@L2JE L2JE requested a review from ronaveva November 16, 2021 20:12
@L2JE L2JE marked this pull request as ready for review November 16, 2021 20:28
@L2JE L2JE requested review from carlosrfranco and removed request for ronaveva November 17, 2021 14:40
@L2JE L2JE changed the title Fix: Appending files instead of overriding RUN-506: Appending files instead of overriding Nov 17, 2021
carlosrfranco
carlosrfranco approved these changes Nov 18, 2021
View reviewed changes
Copy link

@carlosrfranco carlosrfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L2JE L2JE merged commit 1a2622f into master Nov 18, 2021
@L2JE L2JE mentioned this pull request Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosrfranco carlosrfranco carlosrfranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L2JE @carlosrfranco