Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: added new functions to remove or replace the simple quotes #71

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

nvalenzuela20
Copy link
Contributor

#70

Is this a bug fix, or an enhancement? Please describe.
In the project settings section, on the "Node Execution" tab, when the user selects the 'CMD' interpreter and then the user runs a job that executes a command that contains "", "'" or adds options, Rundeck will incorrectly escape them in such a way that CMD cannot run it.

Describe the solution you've implemented
In the python script that sends the command via WinRM, a new function was added that removes or replaces incorrect escaping that were incorrectly added:

  • Adds a flag that when, is activated, fixes incorrect command escaping
  • Search the absolute path and try to replace the simple quotes to double quotes
  • Removes single quotes or replace simple quotes to double quotes enclosing arguments

@nvalenzuela20 nvalenzuela20 marked this pull request as ready for review January 4, 2021 18:54
plugin.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@ltamaster ltamaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants