Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in Ver 9.3.1 #452

Closed
hsytkm opened this issue Oct 29, 2023 · 2 comments
Closed

Breaking change in Ver 9.3.1 #452

hsytkm opened this issue Oct 29, 2023 · 2 comments
Assignees
Labels

Comments

@hsytkm
Copy link

hsytkm commented Oct 29, 2023

Breaking change in Ver 9.3.1

Introduction

I think a breaking change has occurred.
But I have limited knowledge of schedulers.
If there are any problems with my implementation, please let me know.

Platform with bug

WPF

Description

After the ReactiveTimer timer starts in Rp Ver9.3.1, subsequent processing is not executed.

private void Application_Startup(object sender, StartupEventArgs e)
{
    ReactivePropertyScheduler.SetDefault(new ReactivePropertyWpfScheduler(Dispatcher));

    var timer = new ReactiveTimer(TimeSpan.FromSeconds(1), ReactivePropertyScheduler.Default);
    timer.Start();

    // If Rp is Ver9.3.1, it will not reach here.
}

Steps to Reproduce

  1. Set ReactivePropertyWpfScheduler to Rp’s scheduler in Application.Startup.
  2. Create ReactiveTimer with ReactivePropertyScheduler.Default.
  3. Start the timer of the created ReactiveTimer.

Expected behavior

Subsequent processing is executed after ReactiveTimer starts.

Actual behavior

Subsequent processing is not executed after ReactiveTimer starts.

Combination confirmation results

9.3.0 9.3.1
SynchronizationContextScheduler OK OK
ReactivePropertyWpfScheduler OK NG

Environment

  • VisualStudio 2022 17.7.6
  • net48, net6.0-windows
  • ReactiveProperty.WPF 9.3.1

Reproduction Repo

https://github.com/hsytkm/Rp931WpfBreakingChangeDemo

@runceel runceel self-assigned this Oct 29, 2023
runceel added a commit that referenced this issue Oct 29, 2023
@runceel runceel added the bug label Oct 29, 2023
runceel added a commit that referenced this issue Oct 29, 2023
* Update dotnet-core-unit-testing.yml

* ReactivePropertyWpfScheduler throws StackOverflowException. (#436)

* dispatch to ImmediateScheduler
* Incrment version number

* Update dotnet-core-unit-testing.yml

* Remove set-output from workflow (#438)

* Performance improvement for filtered collection (#441)

* Remove LINQ

* increment version number

* detach PropertyChanged events (#445)

* v9.3.3 (#446)

* Bump @babel/traverse from 7.11.0 to 7.23.2 in /docs (#448)

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.11.0 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump browserify-sign from 4.2.1 to 4.2.2 in /docs (#451)

Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* modified it to detach the event from Source.CollectionChanged (#449)

* Update build-and-publish.yml (#454)

* Fix #452 (#453)

* v9.3.4

* v9.3.4 (#455)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Takaaki Suzuki <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ryo1988 <[email protected]>
@runceel
Copy link
Owner

runceel commented Oct 29, 2023

@hsytkm I just published a preview package includes a change for this issue.
Please check it. And if you found an issue related this, please let me know.

https://www.nuget.org/packages/ReactiveProperty.WPF/9.3.4-pre202310290551

@hsytkm
Copy link
Author

hsytkm commented Oct 29, 2023

@runceel I confirm that the expected behavior is working. Thank you for your prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants