Use stringData instead of data for secrets #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amr Farid <[email protected]>
There was a problem hiding this comment.
Thanks for the contribution @afarid. Please bump the patch version for the chart as this is more of a fix, than a feature.
Also from my understanding this is not a breaking change, if anyone thinks it is please do share the reasoning.
GMartinez-Sisti
added
the
waiting-on-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR replaces the use of "data" to use "stringData" for the secrets
why
This allows postrendering script to work as it can parse the secrets values and replace them, For example helmfile vals
https://github.com/helmfile/vals
tests
references