Redis Secret Password Key #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `redisSecretPasswordKey` value Added a new `redisSecretPasswordKey` value that allows users to override the default `password` key used when specifying an existing `Secret` for Redis. This makes for a more seamless integration with popular third-party Redis Helm charts. Signed-off-by: John Lahr <[email protected]>
JohnLahr
force-pushed
the
redis-secret-password-key
branch
from
4b90e6d to
b538425
Compare
|
Hi @JohnLahr, thank you for the contribution! Would you mind adding a couple of unit test cases to test this? |
Co-authored-by: Gabriel Martinez <[email protected]> Signed-off-by: John <[email protected]>
Signed-off-by: John Lahr <[email protected]>
|
@GMartinez-Sisti Added unit tests. Not as familiar with writing tests for charts, but I think I had enough context to work with. Let me know if those aren't sufficient! |
Thanks @JohnLahr! They look great. Now there’s just one small update requirement for the docs. Please check the job that failed. |
Signed-off-by: John Lahr <[email protected]>
JohnLahr
force-pushed
the
redis-secret-password-key
branch
from
77b80fc to
fa9d1d1
Compare
|
Apologies. That should be fixed now 👍 |
Signed-off-by: John Lahr <[email protected]>
GMartinez-Sisti
approved these changes
Nov 4, 2024
No need for apologies! Thank you again for the contribution 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
redisSecretPasswordKeyvaluepasswordvalue as default for backward-compatibilitywhy
This allows users to override the default
passwordkey used when specifying an existingSecretfor Redis. This makes for a more seamless integration with popular third-party Redis Helm charts.For example, the Bitnami Redis chart creates a secret called
<release>-rediswith a key calledredis-passwordwhose value is the password generated for that Redis distribution. Allowing users to specify an arbitrary key name means they can seamlessly integrate that Redis chart with this Atlantis chart and use the same secret.tests
I have tested this successfully in an Amazon EKS cluster.
references
N/A