Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow Github App installation Id #404

Merged

Conversation

bdellegrazie
Copy link
Contributor

Github App Installation Id

  • Add support for specifying this directly in the chart

why

Supplying the installationId directly as part of the Github App configuration is simpler, requires less requests and works when there are multiple installations of the same Github App, as is common for Enterprise setups.

tests

  • I have tested my changes by deploying Atlantis in an environment that requires an installation ID, previously using the environment variable directly.

references

Compliments:
runatlantis/atlantis#4650

@bdellegrazie bdellegrazie requested a review from a team as a code owner July 5, 2024 19:36
@GMartinez-Sisti
Copy link
Member

Hi @bdellegrazie, thanks for the contribution! Can you also please:

  • bump the minor field from Chart.yaml since this is a new feature
  • update the schema for githubApp to include the new field
  • update docs by running make docs from the git root folder

Thank you 🙏

@GMartinez-Sisti GMartinez-Sisti added the waiting-on-response Waiting for a response from the user label Jul 7, 2024
@bdellegrazie
Copy link
Contributor Author

Hi @GMartinez-Sisti,

Updated as requested - thanks

* updated version
* updated schema
* updated docs
Copy link
Member

@GMartinez-Sisti GMartinez-Sisti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GMartinez-Sisti GMartinez-Sisti merged commit 788d495 into runatlantis:main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants