-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(atlantis): use auto generated docs #371
docs(atlantis): use auto generated docs #371
Conversation
972f1a4
to
138907c
Compare
138907c
to
0998970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Deprecated in favor of orgAllowlist | ||
# orgWhitelist: <replace-me> | ||
# -- Deprecated in favor of orgAllowlist. | ||
orgWhitelist: "<replace-me>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GMartinez-Sisti orgWhitelist
seems to be taking precedence now that it is uncommented, breaking configs with orgAllowlist
set.
- name: ATLANTIS_REPO_ALLOWLIST
- value: foo.bar/some/repo
+ value: <replace-me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what
.github/workflows/sync-readme.yaml
)why
The current documentation is hard to manage and we can't ensure it was up to date programatically.
tests
I have tested my changes by adding a step that ensures docs are up to date. Example of CI failure here.
references
Closes #230.