Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add command to values.schema.json #336

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix: add command to values.schema.json #336

merged 2 commits into from
Nov 15, 2023

Conversation

pippitt
Copy link
Contributor

@pippitt pippitt commented Nov 15, 2023 •
edited
Loading

what

  • Add missing value (command) to the values.schema.json

tests

  • helm templating and lint

references

@pippitt pippitt requested a review from a team as a code owner November 15, 2023 17:54
@jamengual
Copy link
Contributor

@pippitt please bump the chart version please
@roytev FYI

@jamengual
Copy link
Contributor

@pippitt Thanks for the contribution

@jamengual jamengual merged commit c86eab1 into runatlantis:main Nov 15, 2023
2 checks passed
@pippitt
Copy link
Contributor Author

pippitt commented Nov 15, 2023

@pippitt Thanks for the contribution

No problem, I was happy I could help out as I'm a user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.17.0/1 values.schema.json doesn't allow for command
2 participants
@pippitt @jamengual