commenting out default servicemonitor auth to avoid checkov CKV_SECRET_6 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rwd5213, even thought there's no actual change, it's a good practice to bump the chart. Bumping the patch version would be enough. |
|
@GMartinez-Sisti Fixed both, thanks |
GMartinez-Sisti
approved these changes
Oct 16, 2023
jamengual
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Commenting out the default password and username setting for service monitor authentication to avoid running into the checkov SECRET_6 compliance check.
why
Since its disabled by default any way there should be no harm in commenting out the actual setting of the password and prevents people from deploying with a default password if they do enable the auth check for the service monitor. Commented out and left for reference of users that want to set it.
tests
Running checkov against charts with it commented out does not make the error occur.
references