-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove deprecated pvc setup for atlantis data dir #197
feat: remove deprecated pvc setup for atlantis data dir #197
Conversation
Hello, I participate to Hacktoberfest, is it possible to add a |
sure, but we need to review it first |
hello @jamengual |
Hello @jhaumont please rebase your branch |
Hello @GenPage done :) |
Instead of removing the pvc, could we disable it instead in case people still want to use it? Is there a need to deprecate it? |
I don't understand. I don't remove the PVC here. I just remove the deprecated values to declare it. We have change the way to do it in another PR #173 with |
@nitrocode 🖖 any update regarding the merge of this one? |
@@ -3,7 +3,7 @@ apiVersion: v1 | |||
appVersion: v0.23.1 | |||
description: A Helm chart for Atlantis https://www.runatlantis.io | |||
name: atlantis | |||
version: 4.12.0 | |||
version: 5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you folks think? @runatlantis/maintainers
Are we ready to do a 5.x? Or should we wait for more interface refactoring before a major upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that since this is a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move forward with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamengual We can, just need to coordinate version bumps with pending PRs
Looks like the chart version is a conflict even though it bumps to 5.0 |
@jhaumont could you fix the conflicts? Thanks. |
@jamengual done, you will merge it ? 🙏 |
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
what
why
tests
references