Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bigger logo on the web pages #783

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Use bigger logo on the web pages #783

merged 3 commits into from
Oct 4, 2019

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Sep 20, 2019

Implements #769

  • It is responsive, with logo size based on viewport height.
  • It does not take up a lot of extra height due to reduction in whitespace above the image.
  • If you want, you can also reclaim some more whitespace below the logo. Currently there are 2 horizontal rules separated by 65 pixels (on my browser) that could be collapsed into 1, allowing 2 more locks to be listed on the page.

LockList


Lock

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #783 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   72.78%   72.78%           
=======================================
  Files          63       63           
  Lines        4807     4807           
=======================================
  Hits         3499     3499           
  Misses       1050     1050           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4dc33d...08127b2. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what went wrong here but I don't think it should look like this?

image

go.mod Outdated
@@ -65,3 +65,5 @@ require (
gopkg.in/yaml.v2 v2.2.2
gotest.tools v2.2.0+incompatible // indirect
)

replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was required to get atlantis to build on my system. I am not a go developer and do not know how the go module system works, so I cannot give you a definitive explanation. All I can say is that those lines were added by my IDE, apparently because go.sum refers to git.apache.org/thrift.git which no longer exists, and the content has been moved to https://github.com/apache/thrift

My brief investigation suggested that this was not a direct requirement of atlantis but rather a requirement of a module atlantis depends on, so I was not able to fix it by directly changing the reference in go.sum.

It is irrelevant to the changes that implement the goals of the PR, but I left it in for the atlantis team to see and make a proper fix.

@Nuru
Copy link
Contributor Author

Nuru commented Oct 4, 2019

Not sure what went wrong here but I don't think it should look like this?

No, it shouldn't. It looks like your installation is not picking up the CSS changes. Given that the CSS is compiled into server/static/bindata_assetfs.go for distribution I don't know how developers are supposed to pick up changes during development. See #782

@lkysow
Copy link
Member

lkysow commented Oct 4, 2019

I had to do a hard refresh. Looks good!

@lkysow lkysow merged commit 86a56a3 into runatlantis:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants