-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bigger logo on the web pages #783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 72.78% 72.78%
=======================================
Files 63 63
Lines 4807 4807
=======================================
Hits 3499 3499
Misses 1050 1050
Partials 258 258 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.mod
Outdated
@@ -65,3 +65,5 @@ require ( | |||
gopkg.in/yaml.v2 v2.2.2 | |||
gotest.tools v2.2.0+incompatible // indirect | |||
) | |||
|
|||
replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was required to get atlantis
to build on my system. I am not a go
developer and do not know how the go
module system works, so I cannot give you a definitive explanation. All I can say is that those lines were added by my IDE, apparently because go.sum
refers to git.apache.org/thrift.git
which no longer exists, and the content has been moved to https://github.com/apache/thrift
My brief investigation suggested that this was not a direct requirement of atlantis
but rather a requirement of a module atlantis
depends on, so I was not able to fix it by directly changing the reference in go.sum
.
It is irrelevant to the changes that implement the goals of the PR, but I left it in for the atlantis
team to see and make a proper fix.
No, it shouldn't. It looks like your installation is not picking up the CSS changes. Given that the CSS is compiled into |
I had to do a hard refresh. Looks good! |
Implements #769