Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var step to workflows #751

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Add var step to workflows #751

merged 2 commits into from
Aug 21, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Aug 21, 2019

Add new var step for setting environment variable in workflows.

Squashes and refactors #656, fixes #370

anasinnyk and others added 2 commits August 21, 2019 15:06
Add new var step for setting environment variable in workflows.
Also some refactoring and testing.
@lkysow lkysow force-pushed the var-step-refactor branch from 6edfb2f to c646f20 Compare August 21, 2019 13:12
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #751 into master will increase coverage by 0.4%.
The diff coverage is 97.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #751     +/-   ##
=========================================
+ Coverage   72.25%   72.65%   +0.4%     
=========================================
  Files          62       63      +1     
  Lines        4728     4794     +66     
=========================================
+ Hits         3416     3483     +67     
+ Misses       1057     1056      -1     
  Partials      255      255
Impacted Files Coverage Δ
server/events/yaml/valid/repo_cfg.go 19.04% <ø> (ø) ⬆️
server/events/runtime/runtime.go 78.94% <ø> (ø) ⬆️
server/events/runtime/init_step_runner.go 83.33% <100%> (ø) ⬆️
server/events/runtime/plan_step_runner.go 87.2% <100%> (ø) ⬆️
server/server.go 64.35% <100%> (+0.35%) ⬆️
server/events/runtime/run_step_runner.go 90.47% <100%> (+0.47%) ⬆️
server/events/runtime/env_step_runner.go 100% <100%> (ø)
server/events/runtime/apply_step_runner.go 85.98% <100%> (ø) ⬆️
server/events/project_command_runner.go 74.1% <100%> (+1.2%) ⬆️
server/events/yaml/raw/step.go 96.12% <100%> (+5.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb16b1...c646f20. Read the comment docs.

@lkysow lkysow merged commit 3851df8 into master Aug 21, 2019
@lkysow lkysow deleted the var-step-refactor branch August 21, 2019 13:15
@lkysow lkysow mentioned this pull request Aug 21, 2019
@lkysow lkysow mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement BASH_ENV functionality to share env vars between steps.
2 participants