-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dumb-init and gosu versions #730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 62 62
Lines 4728 4728
=======================================
Hits 3416 3416
Misses 1057 1057
Partials 255 255 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 62 62
Lines 4728 4728
=======================================
Hits 3416 3416
Misses 1057 1057
Partials 255 255 Continue to review full report at Codecov.
|
Hi Chenrui, |
Yeah, I do see the value of bumping the versions of Release notes: v1.2.2 released on Aug 1, 2018Fix a race condition which can cause the child to receive SIGHUP and SIGCONT very shortly after start.In general this was very rare, but some environments (especially some container and virtualization environments) appear to encounter it at a much higher rate, possibly due to scheduler quirks. v1.2.1 released on Dec 1, 2017Fix verbose debug logging for ignored signals.Before this patch, they were reported in the verbose log as "forwarded Since signal 0 is a noop, there is no actual behavior change here. Fix Python package installation on platforms without -static support (e.g. Mac OS X) |
For Gosu one it is nice to have upgrade. releases notes 1.11 released on Oct 15, 2018
|
in general, it might be a good strategy to keep these releases up to date. As I read thru these release notes, I did not see any issues myself (and I already used the patches myself). |
👍 thanks for the summary |
Upgrade dumb-init and gosu versions the latest