Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bitbucket server pr:deleted event #510

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 1, 2019

If a pull request is deleted, Atlantis should delete the locks.
Fixes #498

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #510 into master will decrease coverage by 1.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #510      +/-   ##
=========================================
- Coverage   71.57%   69.9%   -1.67%     
=========================================
  Files          62      62              
  Lines        4464    4466       +2     
=========================================
- Hits         3195    3122      -73     
- Misses       1031    1106      +75     
  Partials      238     238
Impacted Files Coverage Δ
server/events_controller.go 62.12% <100%> (+8.93%) ⬆️
server/events/event_parser.go 87.97% <100%> (ø) ⬆️
server/logging/simple_logger.go 88.88% <100%> (+0.13%) ⬆️
server/events/runtime/apply_step_runner.go 38.18% <0%> (-48.19%) ⬇️
server/events/terraform/terraform_client.go 47.15% <0%> (-31.71%) ⬇️
server/events/vcs/bitbucketserver/client.go 33.33% <0%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308a873...2fb8f4d. Read the comment docs.

If a pull request is deleted, Atlantis should delete the locks.
Fixes #498
@lkysow lkysow force-pushed the bb-server-delete-event branch from 072f446 to 2fb8f4d Compare March 1, 2019 16:36
@lkysow lkysow merged commit c97c922 into master Mar 1, 2019
@lkysow lkysow deleted the bb-server-delete-event branch March 1, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant