Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add notes to default tags #4853

Merged
merged 2 commits into from
Aug 31, 2024
Merged

chore(docs): add notes to default tags #4853

merged 2 commits into from
Aug 31, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Aug 17, 2024 •
edited
Loading

what

  • chore(docs): add notes to default tags

why

  • Explain each environment variable
  • Explain how to run local plans
  • Explain colon usage (as per aws best tagging practices) in environment variables
  • Use BASE instead of HEAD to avoid a forked repository from appending the tag instead of the base repository

tests

N/A

references

@nitrocode nitrocode requested review from a team as code owners August 17, 2024 16:20
@nitrocode nitrocode requested review from GenPage, lukemassa and X-Guardian and removed request for a team August 17, 2024 16:20
@github-actions github-actions bot added docs Documentation size/s labels Aug 17, 2024
@nitrocode nitrocode enabled auto-merge (squash) August 17, 2024 16:21
@nitrocode nitrocode merged commit c7ff179 into main Aug 31, 2024
27 checks passed
@nitrocode nitrocode deleted the custom-workflow-default-tags-notes branch August 31, 2024 15:21
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemassa lukemassa lukemassa approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
docs Documentation size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @lukemassa