Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix placement of top header #4559

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

jippi
Copy link
Contributor

@jippi jippi commented May 14, 2024

what

The header is placed kinda odd (pic 1) and not aligned with the rest of the header

Zight 2024-05-14 at 10 35 12 PM jpg

leading to content scrolling "behind" the header (pic 2)

Zight 2024-05-14 at 10 35 51 PM jpg

if we remove the padding-top it looks correct (pic 3)

Zight 2024-05-14 at 10 36 28 PM jpg

and matches the native vitepress design (pic 4)

Zight 2024-05-14 at 10 37 29 PM jpg

why

It looks nice

tests

N/A

references

N/A

@jippi jippi requested review from a team as code owners May 14, 2024 20:37
@jippi jippi requested review from jamengual, nitrocode and X-Guardian and removed request for a team May 14, 2024 20:37
@chenrui333 chenrui333 merged commit ad5f978 into runatlantis:main May 14, 2024
25 checks passed
@jippi jippi deleted the fix-header branch May 14, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants