Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 #4534

Merged
merged 2 commits into from
May 14, 2024
Merged

chore(deps): terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 #4534

merged 2 commits into from
May 14, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 10, 2024 •
edited
Loading

fix e2e tests

image

@chenrui333 chenrui333 requested review from a team as code owners May 10, 2024 18:35
@chenrui333 chenrui333 requested review from jamengual, nitrocode and X-Guardian and removed request for a team May 10, 2024 18:35
@github-actions github-actions bot added build Relating to how we build Atlantis size/xs labels May 10, 2024
@chenrui333 chenrui333 changed the title deps: terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 chore: terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 May 10, 2024
@chenrui333 chenrui333 force-pushed the update-deps-20240510 branch from 584815c to cd90ef4 Compare May 10, 2024 18:38
@chenrui333 chenrui333 changed the title chore: terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 chore(deps): terraform 1.8.3, opentofu 1.7.1, conftest 0.52.0 May 10, 2024
@github-actions github-actions bot added go Pull requests that update Go code provider/github size/s and removed size/xs labels May 10, 2024
nitrocode
nitrocode previously approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch tests still seem to be failing

@chenrui333
Copy link
Member Author

still need a bit work :)

@erpel
Copy link
Contributor

erpel commented May 13, 2024

Would it be an option to include the fix from #4381 in this one? Would mean that future upgrades of this kind could again be prepared by a bot.

@chenrui333
Copy link
Member Author

we can totally do in two prs, I dont see why not. I need to debug a bit why the e2e tests failing.

@chenrui333 chenrui333 force-pushed the update-deps-20240510 branch from 8aa6647 to b5a27c9 Compare May 14, 2024 16:45
@chenrui333

This comment was marked as resolved.

Sign in to view
@chenrui333 chenrui333 requested a review from nitrocode May 14, 2024 16:46
@chenrui333 chenrui333 force-pushed the update-deps-20240510 branch from b5a27c9 to d7d644d Compare May 14, 2024 16:49
@chenrui333 chenrui333 enabled auto-merge (squash) May 14, 2024 17:09
@chenrui333 chenrui333 merged commit a630646 into main May 14, 2024
28 checks passed
@chenrui333 chenrui333 deleted the update-deps-20240510 branch May 14, 2024 17:38
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
build Relating to how we build Atlantis go Pull requests that update Go code provider/github size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @erpel @jamengual @nitrocode