fix: logger nil pointer in instrumented_project_command_builder

[jippi]

what

Running the latest main on testing yielded this message from Atlantis.

Submitting it as-is since its end-of-week, and others might be hitting the issue.

runtime error: invalid memory address or nil pointer dereference
runtime/panic.go:261 (0x454cb7)
runtime/signal_unix.go:881 (0x454c85)
github.com/runatlantis/atlantis/server/events/instrumented_project_command_builder.go:75 (0x106ba3a)
github.com/runatlantis/atlantis/server/events/instrumented_project_command_builder.go:35 (0x106b58a)
github.com/runatlantis/atlantis/server/events/plan_command_runner.go:194 (0x1074081)
github.com/runatlantis/atlantis/server/events/plan_command_runner.go:306 (0x1075844)
github.com/runatlantis/atlantis/server/events/command_runner.go:367 (0x1059483)
runtime/asm_amd64.s:1695 (0x4725c0)

why

A refactor should have passed in the logger to the struct.

tests

• No more nil-pointer panics in our testing environment

[jippi]

🤔 I'm not sure why the tests are failing - would love some hints - not familiar enough with the output produced to effectively triage it

Seems to be related to + keepers = {} being in the output from TF - but my changes shouldn't (??) have affected any of that behavior?

[jamengual]

they are failing in all PRs, not just yours. We need to look into this

…

On Fri, Apr 19, 2024 at 12:15 PM Christian Winther ***@***.***> wrote: 🤔 I'm not sure why the tests are failing - would love some hints - not familiar enough with the output produced to effectively triage it — Reply to this email directly, view it on GitHub <#4461 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERFZZRJHCHFCRCWGRLLY6FUN3AVCNFSM6AAAAABGPRR7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGE2TENZQHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[jippi]

Should be fixed in #4462 once the pipelines complete

[jamengual]

@jippi could you update you branch and push the changes?

[jippi]

@jamengual Done 👍

[lukemassa]

/cherry-pick release-0.27