fix: Docker terraform/tofu binaries not copied to final Docker image

[jippi]

what

I pulled in main to my internal testing site, and the container image failed to start with this error.

Error: initializing server: initializing terraform: terraform not found in $PATH. Set --default-tf-version or download terraform from https://developer.hashicorp.com/terraform/downloads

When I inspected /usr/local/bin in the container, I noticed none of the binaries were present.

$ find /usr/local/bin
/usr/local/bin
/usr/local/bin/docker-entrypoint.sh
/usr/local/bin/conftest
/usr/local/bin/atlantis

why

It looks like the #4341 refactor did not account for the new paths to be copied into the container.

This change rectifies this - /usr/local/bin now looks like this

$ find /usr/local/bin/
/usr/local/bin/
/usr/local/bin/docker-entrypoint.sh
/usr/local/bin/conftest
/usr/local/bin/tofu
/usr/local/bin/terraform
/usr/local/bin/opentofu
/usr/local/bin/opentofu/1.6.2
/usr/local/bin/opentofu/1.6.2/CHANGELOG.md
/usr/local/bin/opentofu/1.6.2/tofu
/usr/local/bin/opentofu/1.6.2/LICENSE
/usr/local/bin/opentofu/1.6.2/README.md
/usr/local/bin/tf
/usr/local/bin/tf/1.5.7
/usr/local/bin/tf/1.5.7/terraform
/usr/local/bin/tf/1.8.0
/usr/local/bin/tf/1.8.0/terraform
/usr/local/bin/tf/1.6.6
/usr/local/bin/tf/1.6.6/terraform
/usr/local/bin/tf/1.7.5
/usr/local/bin/tf/1.7.5/terraform
/usr/local/bin/atlantis

tests

• docker run --rm -it ghcr.io/runatlantis/atlantis:$(TAG) ls /usr/local/bin should return the files
• docker run --rm -it ghcr.io/runatlantis/atlantis:$(TAG) tofu should work
• docker run --rm -it ghcr.io/runatlantis/atlantis:$(TAG) terraform should work

[nitrocode]

Thanks for the contribution. Someone found the issue and proposed another solution already.

Related PR #4439

[jippi]

Cool! I missed the PR while looking for existing solutions - happy as long as its fixed