Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move Web Templates to External Files #4384

Merged
merged 8 commits into from
Apr 1, 2024
Merged

chore: Move Web Templates to External Files #4384

merged 8 commits into from
Apr 1, 2024

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Mar 24, 2024 •
edited by nitrocode
Loading

what

Move the html go templates from the web_templates package into external files.

why

  • Match the pattern used by markdown_renderer in the events package.
  • Benefit from linting on the external go templates.

tests

Tested locally

references

@X-Guardian X-Guardian marked this pull request as ready for review March 28, 2024 09:09
@X-Guardian X-Guardian requested review from a team as code owners March 28, 2024 09:09
@X-Guardian X-Guardian requested review from GenPage, lukemassa and nitrocode and removed request for a team March 28, 2024 09:10
@github-actions github-actions bot added the go Pull requests that update Go code label Mar 28, 2024
@X-Guardian X-Guardian requested review from a team, chenrui333, lukemassa and nitrocode and removed request for a team March 28, 2024 14:40
@X-Guardian X-Guardian enabled auto-merge (squash) April 1, 2024 10:18
@X-Guardian X-Guardian merged commit f0312e3 into runatlantis:main Apr 1, 2024
24 checks passed
@X-Guardian X-Guardian deleted the web-templates-embed branch April 1, 2024 10:41
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMartinez-Sisti GMartinez-Sisti GMartinez-Sisti approved these changes

@nitrocode nitrocode nitrocode approved these changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333 chenrui333 is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@X-Guardian @nitrocode @GMartinez-Sisti