fix: Make PolicyCheckSummary rendering optional #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourava01
requested review from
chenrui333,
lukemassa and
nitrocode
and removed request for
a team
sourava01
changed the title
GenPage
added
bug
GenPage
approved these changes
Mar 27, 2024
|
/cherry-pick release-0.27 |
1 task
chenrui333
pushed a commit
that referenced
this pull request
Jun 16, 2024
…4387) Co-authored-by: Sourav Agrawal <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
When using custom policy checking, PolicyCheckSummary is empty. This creates an empty codeblock in the output which is misleading.
Example Image
why
Empty codeblock is misleading! At first glance, it gives the impression that it is an empty output / policy checks have passed.
tests
references