Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refine the logging in the Working Dir Package #4294

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Feb 28, 2024

what

This PR refines the logging in the Atlantis Working Dir package.

Also changes %q in the logging strings to '%s' to prevent the double quotes created by %q in the string needing to be escaped in the JSON log output.

why

Improve the Atlantis debug logging. Working dir logging entries will now be included in the --verbose output when running Atlantis commands, making trouble shooting easier, as debug logs for a command can be produced without having to run the Atlantis server with the debug log level.

tests

Tested locally

references

@X-Guardian X-Guardian requested review from a team as code owners February 28, 2024 21:17
@X-Guardian X-Guardian requested review from GenPage, lukemassa and nitrocode and removed request for a team February 28, 2024 21:17
@github-actions github-actions bot added go Pull requests that update Go code provider/github labels Feb 28, 2024
@X-Guardian X-Guardian changed the title feat :Refine the logging in the Working Dir Package feat: Refine the logging in the Working Dir Package Feb 28, 2024
GenPage
GenPage previously approved these changes Feb 29, 2024
@GenPage GenPage added the feature New functionality/enhancement label Feb 29, 2024
@X-Guardian
Copy link
Contributor Author

@GenPage, this PR is ready for re-review. I fixed the failing tests.

@GenPage GenPage enabled auto-merge (squash) March 27, 2024 16:03
@GenPage GenPage added the refactoring Code refactoring that doesn't add additional functionality label Mar 27, 2024
@GenPage GenPage merged commit b221fdc into runatlantis:main Mar 27, 2024
23 of 24 checks passed
@X-Guardian X-Guardian deleted the working-dir-logging-refinement branch March 28, 2024 09:03
@chenrui333 chenrui333 added this to the v0.28.0 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement go Pull requests that update Go code provider/github refactoring Code refactoring that doesn't add additional functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants