fix: update go version in go.mod #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sh $ go version go: downloading go1.22 (darwin/arm64) go: download go1.22 for darwin/arm64: toolchain not available ``` after the change ```sh $ go version go: downloading go1.22.0 (darwin/arm64) go version go1.22.0 darwin/arm64 ``` Signed-off-by: Rui Chen <[email protected]>
chenrui333
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
|
Not sure if we want to pursue this PR, the fundamental issue is with the go installation, it only happened when the global default is go1.21, if you have go1.22 installed, then you wont see go toolchain download issue. I guess it helps to smooth the local dev frustration though. |
X-Guardian
approved these changes
Feb 26, 2024
nitrocode
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ go version go: downloading go1.22 (darwin/arm64) go: download go1.22 for darwin/arm64: toolchain not availableafter the change
Thanks @lukemassa for calling it out.