fix: Prevent panics when logging HTTP response status in github and gitlab client

[adkafka]

what

Fixes #4081

why

Wraps any logging that was added from #3876 with an if resp != nil check, to avoid any panics

tests

N/A

references

• Atlantis v0.27.0 hits nil pointer dereference panic on github client #4081
• feat: Improve GitHub and GitLab Debug Logging #3876

[lukemassa]

I think you missed two:

• atlantis/server/events/vcs/github_client.go

  Line 614 in 25d8bb7

  g.logger.Debug("GET /repos/%v/%v returned: %v", pull.BaseRepo.Owner, pull.BaseRepo.Name, resp.StatusCode)

• atlantis/server/events/vcs/gitlab_client.go

  Line 197 in 25d8bb7

  g.logger.Debug("POST /projects/%s/merge_requests/%d/notes/%d/award_emoji returned: %d", repo.FullName, pullNum, commentID, resp.StatusCode)

I found these by running the following:

atlantis % grep -r 'logger.Debug.*resp.StatusCode' server -B1 | grep -v logger.Debug | grep -v 'resp.*nil' | grep server 
server/events/vcs/gitlab_client.go-	_, resp, err := g.Client.AwardEmoji.CreateMergeRequestAwardEmojiOnNote(repo.FullName, pullNum, int(commentID), &gitlab.CreateAwardEmojiOptions{Name: reaction})
server/events/vcs/github_client.go-	repo, resp, err := g.client.Repositories.Get(g.ctx, pull.BaseRepo.Owner, pull.BaseRepo.Name)

I mentioned in #4081 that it might be worth creating a helper function to handle this in a generic way, but I personally am OK with accepting this PR as is since it explicitly and in a straightforward way guards against panics. We should follow up with a more holistic fix (for example, since this approach means that we don't get logs when err != nil, which would likely be useful.)

[adkafka]

Thanks for catching these! I just added fixes for both to this PR. I agree, that there may be better ways to solve this. I saw a simple fix, so I thought it was worth proposing. I'd argue that it is worth merging this to fix things, and we can always follow-up with a refactor if that is desired, but I'll let you guys decide.

[chenrui333]

lgtm

[lukemassa]

/cherry-pick release-0.27