Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump curl from 8.4 to 8.5 #4019

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

lukemassa
Copy link
Contributor

@lukemassa lukemassa commented Dec 8, 2023

what

Use new version curl 8.5, since 8.4 is now absent from alpine.

why

#3911 is failing tests because of:

 > [linux/amd64 alpine 8/8] RUN apk add --no-cache         ca-certificates~=20230506         curl~=8.4         git~=2.40         unzip~=6.0         bash~=5.2         openssh~=9.3_p2         dumb-init~=1.2         gcompat~=1.1:
0.175 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
0.353 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
0.774 ERROR: unable to select packages:
0.776   curl-8.5.0-r0:
0.776     breaks: world[curl~8.4]

This seems to be because curl released 8.5.0 a few days ago: https://curl.se/changes.html#8_5_0

Alpine apparently only keeps the newest: https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/

[curl-8.5.0-r0.apk](https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/curl-8.5.0-r0.apk)                                  07-Dec-2023 08:40    146K

tests

Before:

atlantis % docker buildx build --target alpine .                          
...                                                                                                                          
 > [alpine 8/8] RUN apk add --no-cache         ca-certificates~=20230506         curl~=8.4         git~=2.40         unzip~=6.0         bash~=5.2         openssh~=9.3_p2         dumb-init~=1.2         gcompat~=1.1:                                                                                                                                                        
0.161 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
1.361 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
2.006 ERROR: unable to select packages:
2.008   curl-8.5.0-r0:
2.008     breaks: world[curl~8.4]
------
Dockerfile:159

After:

atlantis % docker buildx build --target alpine .
...
 => [alpine 8/8] RUN apk add --no-cache         ca-certificates~=20230506         curl~=8         git~=2.40         unzip~=6.0         bash~=5.2         openssh~=9.3_p2          4.4s
 => exporting to image                                                                                                                                                            1.5s
 => => exporting layers   

references

@lukemassa lukemassa requested a review from a team as a code owner December 8, 2023 00:01
@github-actions github-actions bot added the build Relating to how we build Atlantis label Dec 8, 2023
@lukemassa lukemassa changed the title fix: Relax constraint for installing curl fix: Bump curl from 8.4 to 8.5 Dec 8, 2023
@jamengual jamengual merged commit f9cab6a into runatlantis:main Dec 8, 2023
23 checks passed
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* fix: Relax constraint for installing curl

* Update Dockerfile
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* fix: Relax constraint for installing curl

* Update Dockerfile
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
* fix: Relax constraint for installing curl

* Update Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Relating to how we build Atlantis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants