fix: Atlantis Does Not Consider the Plan Directory When Hiding Previous Plan Comments #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider/azuredevops
go
|
@GenPage, this PR is ready for review. |
lukemassa
approved these changes
Dec 23, 2023
chenrui333
approved these changes
Dec 29, 2023
|
/cherry-pick release-0.27 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…us Plan Comments (#4012) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go
lukemassa
pushed a commit
that referenced
this pull request
Jan 19, 2024
…us Plan Comments (#4012) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go
lukemassa
pushed a commit
that referenced
this pull request
Jan 19, 2024
…us Plan Comments (#4012) (#4130) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go Co-authored-by: Simon Heather <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…us Plan Comments (runatlantis#4012) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…us Plan Comments (runatlantis#4012) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Update the GitHub and GitLab
HidePrevCommandCommentsfunctions to check for the comment directory when hiding previous plan comments.why
tests
Tested Locally