feat(api): change the defaults for BaseBranch and HeadCommit #3984
Conversation
As of now, the /api/plan endpoint constructs a PullRequest that uses the provided Ref parameter as the base branch and head commit. This causes issues when running additional steps along with plan (e.g.: policy check, infracost, etc). Here's an example error: ``` repo was already cloned but is not at correct commit, wanted \"pr-plan-test\" got \"7a19f2011...\" ``` This will then trigger a new clone which will override needed artifacts from the previous steps which will then cause /api/plan to fail. By properly setting HeadCommit to HEAD this issue is avoided. Signed-off-by: Raul Gutierrez Segales <[email protected]>
rgs1
force-pushed
the
fix-defaults-plan-api
branch
from
fe7f367 to
355bfaa
Compare
rgs1
changed the title
jamengual
added
waiting-on-review
|
What would happen to people where the base branch is still |
|
This is actually not quite right, closing for now and will follow-up with the right fix. |
Sorry closed before seeing this comment -- yeah I think the right approach is to extend |
|
Thanks @rgs1, we have been trying to implement Drift detection in atlantis natively since https://github.com/cresta/atlantis-drift-detection came out, if you have time and know golang well, contact me in Slack. |
|
Follow-up in #3985. |
As of now, the /api/plan endpoint constructs a PullRequest that uses the provided Ref parameter as the base branch and head commit. This causes issues when running additional steps along with plan (e.g.: policy check, infracost, etc).
Here's an example error:
This will then trigger a new clone which will override needed artifacts from the previous steps which will then cause /api/plan to fail.
By properly setting HeadCommit to HEAD this issue is avoided.