-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add misspell check for linting codebase #3865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` server/events/vcs/instrumented_client.go:46:26: `soley` is a misspelling of `solely` (misspell) // methods and implement soley any github specific interfaces. ^ server/events/project_command_context_builder.go:49:5: `Conciously` is a misspelling of `Consciously` (misspell) // Conciously making this global since it gets flushed periodically anyways ^ server/controllers/events/gitlab_request_parser_validator.go:87:32: `noteable` is a misspelling of `notable` (misspell) NoteableType string `json:"noteable_type"` ^ server/controllers/events/gitlab_request_parser_validator_test.go:351:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "MergeRequest", ^ server/controllers/events/gitlab_request_parser_validator_test.go:359:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": 7, ^ server/controllers/events/gitlab_request_parser_validator_test.go:467:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "Commit", ^ server/controllers/events/gitlab_request_parser_validator_test.go:475:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": null, ^ server/events/event_parser_test.go:1012:23: `seperate` is a misspelling of `separate` (misspell) // If sha changes in seperate PR, ^ ``` Signed-off-by: Rui Chen <[email protected]>
chenrui333
changed the title
lint: add misspell check
fix: add misspell check for linting codebase
Oct 16, 2023
Signed-off-by: Rui Chen <[email protected]>
jamengual
reviewed
Oct 16, 2023
This reverts commit 7cc56af.
Signed-off-by: Rui Chen <[email protected]>
jamengual
approved these changes
Oct 16, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* add misspell check * lint: fix misspell issues ``` server/events/vcs/instrumented_client.go:46:26: `soley` is a misspelling of `solely` (misspell) // methods and implement soley any github specific interfaces. ^ server/events/project_command_context_builder.go:49:5: `Conciously` is a misspelling of `Consciously` (misspell) // Conciously making this global since it gets flushed periodically anyways ^ server/controllers/events/gitlab_request_parser_validator.go:87:32: `noteable` is a misspelling of `notable` (misspell) NoteableType string `json:"noteable_type"` ^ server/controllers/events/gitlab_request_parser_validator_test.go:351:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "MergeRequest", ^ server/controllers/events/gitlab_request_parser_validator_test.go:359:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": 7, ^ server/controllers/events/gitlab_request_parser_validator_test.go:467:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "Commit", ^ server/controllers/events/gitlab_request_parser_validator_test.go:475:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": null, ^ server/events/event_parser_test.go:1012:23: `seperate` is a misspelling of `separate` (misspell) // If sha changes in seperate PR, ^ ``` Signed-off-by: Rui Chen <[email protected]> * add locale setting Signed-off-by: Rui Chen <[email protected]> * Revert "lint: fix misspell issues" This reverts commit 7cc56af. * lint: fix some misspell issues Signed-off-by: Rui Chen <[email protected]> --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* add misspell check * lint: fix misspell issues ``` server/events/vcs/instrumented_client.go:46:26: `soley` is a misspelling of `solely` (misspell) // methods and implement soley any github specific interfaces. ^ server/events/project_command_context_builder.go:49:5: `Conciously` is a misspelling of `Consciously` (misspell) // Conciously making this global since it gets flushed periodically anyways ^ server/controllers/events/gitlab_request_parser_validator.go:87:32: `noteable` is a misspelling of `notable` (misspell) NoteableType string `json:"noteable_type"` ^ server/controllers/events/gitlab_request_parser_validator_test.go:351:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "MergeRequest", ^ server/controllers/events/gitlab_request_parser_validator_test.go:359:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": 7, ^ server/controllers/events/gitlab_request_parser_validator_test.go:467:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "Commit", ^ server/controllers/events/gitlab_request_parser_validator_test.go:475:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": null, ^ server/events/event_parser_test.go:1012:23: `seperate` is a misspelling of `separate` (misspell) // If sha changes in seperate PR, ^ ``` Signed-off-by: Rui Chen <[email protected]> * add locale setting Signed-off-by: Rui Chen <[email protected]> * Revert "lint: fix misspell issues" This reverts commit 7cc56af. * lint: fix some misspell issues Signed-off-by: Rui Chen <[email protected]> --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
* add misspell check * lint: fix misspell issues ``` server/events/vcs/instrumented_client.go:46:26: `soley` is a misspelling of `solely` (misspell) // methods and implement soley any github specific interfaces. ^ server/events/project_command_context_builder.go:49:5: `Conciously` is a misspelling of `Consciously` (misspell) // Conciously making this global since it gets flushed periodically anyways ^ server/controllers/events/gitlab_request_parser_validator.go:87:32: `noteable` is a misspelling of `notable` (misspell) NoteableType string `json:"noteable_type"` ^ server/controllers/events/gitlab_request_parser_validator_test.go:351:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "MergeRequest", ^ server/controllers/events/gitlab_request_parser_validator_test.go:359:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": 7, ^ server/controllers/events/gitlab_request_parser_validator_test.go:467:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "Commit", ^ server/controllers/events/gitlab_request_parser_validator_test.go:475:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": null, ^ server/events/event_parser_test.go:1012:23: `seperate` is a misspelling of `separate` (misspell) // If sha changes in seperate PR, ^ ``` Signed-off-by: Rui Chen <[email protected]> * add locale setting Signed-off-by: Rui Chen <[email protected]> * Revert "lint: fix misspell issues" This reverts commit 7cc56af. * lint: fix some misspell issues Signed-off-by: Rui Chen <[email protected]> --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
misspell
to improve the codebase quality