fix: set policy_check status to success for PRs with no modified projects #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenPage
requested changes
Sep 25, 2023
| if err := p.commitStatusUpdater.UpdateCombinedCount(baseRepo, pull, models.SuccessCommitStatus, command.PolicyCheck, 0, 0); err != nil { | ||
| ctx.Log.Warn("unable to update commit status: %s", err) | ||
| } | ||
| if err := p.commitStatusUpdater.UpdateCombinedCount(baseRepo, pull, models.SuccessCommitStatus, command.Apply, 0, 0); err != nil { |
There was a problem hiding this comment.
Can we make sure this doesn't affect issues like #3725 and cause a regression?
There was a problem hiding this comment.
Not sure I understand what you are asking here - this part of the code just replicates what autoplan does. Is autoplan broken wrt #3725?
There was a problem hiding this comment.
finnag
force-pushed
the
policycheck-success-on-no-projects
branch
from
3244d82 to
f95ff71
Compare
GenPage
added
waiting-on-response
GenPage
approved these changes
Dec 11, 2023
Autoplan would set the "policy_check" status to successful if there were no modified projects in a PR, but "atlantis plan" would not. Changed "atlantis plan" to behave like autoplan in this regard.
GenPage
force-pushed
the
policycheck-success-on-no-projects
branch
from
49f3389 to
ced9146
Compare
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Autoplan would set the "policy_check" status to successful if there were no modified projects in a PR, but "atlantis plan" would not. Changed "atlantis plan" to behave like autoplan in this regard.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Autoplan would set the "policy_check" status to successful if there were no modified projects in a PR, but "atlantis plan" would not. Changed "atlantis plan" to behave like autoplan in this regard.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
set policy_check status to successful after a
atlantis plancommand finds no projects that are modified. This makesatlantis planbehave likeautoplanin this regard.why
If you have set policy_check as a required status in github, this would only work with autoplan for PRs that did not modify any projects. The code path for autoplan and "atlantis plan" were different in this regard, but autoplan is not always appropriate.
tests
references