Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update the Simple Logger Log Function to log the Correct Caller #3631

Merged
merged 2 commits into from
Jul 30, 2023
Merged

fix: Update the Simple Logger Log Function to log the Correct Caller #3631

merged 2 commits into from
Jul 30, 2023

Conversation

X-Guardian
Copy link
Contributor

what

Fixes the Simple Logger Log function so that the sugared logger is used to log the correct caller, the same as all the other log functions.

why

The wrong caller is currently logged for this function

tests

Locks controller 'Apply Lock' log entry before the change:

{"level":"info","ts":"2023-07-28T14:13:33.829+0100","caller":"logging/simple_logger.go:159","msg":"Apply Lock is acquired on 2023-07-28 14:13:33","json":{}}

after this change:

{"level":"info","ts":"2023-07-28T14:08:03.793+0100","caller":"controllers/locks_controller.go:149","msg":"Apply Lock is acquired on 2023-07-28 14:08:03","json":{}}

@X-Guardian X-Guardian requested a review from a team as a code owner July 28, 2023 13:14
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 28, 2023
@jamengual
Copy link
Contributor

@GenPage

GenPage
GenPage approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing how this was overlooked

@GenPage GenPage merged commit 75b4b06 into runatlantis:main Jul 30, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@X-Guardian @ijames-gc
Fix Simple Logger Log Function (runatlantis#3631)
21caecc
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@X-Guardian @ijames-gc
Fix Simple Logger Log Function (runatlantis#3631)
c94eb28
@pbobba-ocrolus pbobba-ocrolus mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage GenPage approved these changes

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@X-Guardian @jamengual @GenPage