Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest atlantis-base. #363

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Use latest atlantis-base. #363

merged 1 commit into from
Nov 29, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 28, 2018

  • Upon merging Allow arbitrary user to run atlantis #346 I
    manually built and pushed a new version of runatlantis/atlantis-base and
    tagged it as runatlantis/atlantis-base:v2.0. This change uses that new
    tag. Before it was using :latest which isn't good if other people see
    that and use atlantis-base:latest because we could break it for them.
  • I've also put back the fsContext to 1000 because the atlantis user is
    still in that group so we need that for kubernetes.

- Upon merging #346 I
manually built and pushed a new version of runatlantis/atlantis-base and
tagged it as runatlantis/atlantis-base:v2.0. This change uses that new
tag. Before it was using :latest which isn't good if other people see
that and use atlantis-base:latest because we could break it for them.
- I've also put back the fsContext to 1000 because the atlantis user is
still in that group so we need that for kubernetes.
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #363   +/-   ##
======================================
  Coverage    70.6%   70.6%           
======================================
  Files          61      61           
  Lines        3681    3681           
======================================
  Hits         2599    2599           
  Misses        901     901           
  Partials      181     181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4bf27...3cc465b. Read the comment docs.

@lkysow lkysow merged commit 09ecb27 into master Nov 29, 2018
@lkysow lkysow deleted the base branch November 29, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant