fix: Include information about imports in PlanSuccessStats #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform 1.5 introduced a feature to import existing resources into state via code. https://developer.hashicorp.com/terraform/language/import When you run `terraform plan` with imports, the output includes information about the imported resources, which breaks the current regex for parsing plan changes. This PR updates the regex to include the, optional, import information.
william-richard
changed the title
bnu0
reviewed
Jul 24, 2023
Co-authored-by: Benjamin Ullian <[email protected]>
bnu0
approved these changes
Jul 25, 2023
GenPage
approved these changes
Jul 30, 2023
william-richard
deleted the
william-richard-support-terraform-1.5-import
branch
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…is#3621) * Include information about imports in PlanSuccessStats Terraform 1.5 introduced a feature to import existing resources into state via code. https://developer.hashicorp.com/terraform/language/import When you run `terraform plan` with imports, the output includes information about the imported resources, which breaks the current regex for parsing plan changes. This PR updates the regex to include the, optional, import information. * Use the ? Co-authored-by: Benjamin Ullian <[email protected]> --------- Co-authored-by: Will Richard <[email protected]> Co-authored-by: Benjamin Ullian <[email protected]> Co-authored-by: Dylan Page <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…is#3621) * Include information about imports in PlanSuccessStats Terraform 1.5 introduced a feature to import existing resources into state via code. https://developer.hashicorp.com/terraform/language/import When you run `terraform plan` with imports, the output includes information about the imported resources, which breaks the current regex for parsing plan changes. This PR updates the regex to include the, optional, import information. * Use the ? Co-authored-by: Benjamin Ullian <[email protected]> --------- Co-authored-by: Will Richard <[email protected]> Co-authored-by: Benjamin Ullian <[email protected]> Co-authored-by: Dylan Page <[email protected]>
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
…is#3621) * Include information about imports in PlanSuccessStats Terraform 1.5 introduced a feature to import existing resources into state via code. https://developer.hashicorp.com/terraform/language/import When you run `terraform plan` with imports, the output includes information about the imported resources, which breaks the current regex for parsing plan changes. This PR updates the regex to include the, optional, import information. * Use the ? Co-authored-by: Benjamin Ullian <[email protected]> --------- Co-authored-by: Will Richard <[email protected]> Co-authored-by: Benjamin Ullian <[email protected]> Co-authored-by: Dylan Page <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Terraform 1.5 introduced a feature to import existing resources into state via code.
https://developer.hashicorp.com/terraform/language/import
When you run
terraform planwith imports, the output includes information about the imported resources, which breaks the current regex for parsing plan changes.This PR updates the regex to include the, optional, import information.
why
I want Atlantis to output accurate feedback to the user when it runs plans on terraform code including imports.
tests
references