Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add username to main lock screen #3597

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

tobaker
Copy link
Contributor

@tobaker tobaker commented Jul 12, 2023

what

Add the username of the user who owns/created the lock to the main lock screen

why

In our organisation we have many users and teams who make changes to repos controlled by Atlantis. It will be very useful to be able to see at a glance who created the locks, especially when we can have many.

tests

Tested the changes locally by running Atlantis in docker and using ngrok to post webhooks into my test instance of Atlantis.

Atlantis

references

N/A

@tobaker tobaker requested a review from a team as a code owner July 12, 2023 18:38
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 12, 2023
@tobaker tobaker changed the title Feat username lock screen feat: username lock screen Jul 12, 2023
@tobaker tobaker changed the title feat: username lock screen feat: Add username to main lock screen Jul 12, 2023
@tobaker tobaker force-pushed the feat-username-lock-screen branch from cd4bac8 to a0416e0 Compare July 14, 2023 09:04
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice QoL improvement, thank you for the contribution. Auto-merge is enabled once CI is green.

@GenPage GenPage enabled auto-merge (squash) July 17, 2023 15:57
@GenPage GenPage merged commit a791fbf into runatlantis:main Jul 17, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants