fix: parse custom run step output in policy_check #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudomorph
force-pushed
the
fix_custom_run_output_policy_check
branch
from
48eb585 to
b65b85b
Compare
pseudomorph
force-pushed
the
fix_custom_run_output_policy_check
branch
from
b65b85b to
d33561d
Compare
|
@nitrocode - How does this look? Seems to address the issues @Banders2 was seeing |
GenPage
approved these changes
Jun 20, 2023
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
* parse custom run output in policy_check * error if no conftest output * e2e test * Adding other policy template. * update markdown renderer test
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* parse custom run output in policy_check * error if no conftest output * e2e test * Adding other policy template. * update markdown renderer test
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* parse custom run output in policy_check * error if no conftest output * e2e test * Adding other policy template. * update markdown renderer test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Changes in #3086 did not account for custom run steps being implemented in the policy_check workflow step. This addresses that.
Output from custom run steps is separated from the conftest output, and passed to the markdown renderer as separate fields.
why
Some Atlantis deployments have custom run steps in policy_check workflow. Currently this breaks policy parsing and results in an error.
tests
references