Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Refreshing..." output from top of plan. #339

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Oct 30, 2018

When running terraform plan, Terraform writes a line for each resource
it updates. For example:

null_resource.b: Refreshing state... (ID: 700288721293508840)
null_resource.a: Refreshing state... (ID: 2853194762920164292)
null_resource.f: Refreshing state... (ID: 6634469389761751950)

This change removes those lines by splitting the output string after a
separator.

This change is being made because the Refreshing output isn't important
and it will make the comments shorter.

From:
image

To:
image

Notes:

@lkysow lkysow force-pushed the remove-refreshing branch 2 times, most recently from 995be0e to 70128e4 Compare October 30, 2018 21:24
When running terraform plan, Terraform writes a line for each resource
it updates. For example:

	null_resource.b: Refreshing state... (ID: 700288721293508840)
	null_resource.a: Refreshing state... (ID: 2853194762920164292)
	null_resource.f: Refreshing state... (ID: 6634469389761751950)

This change removes those lines by splitting the output string after a
separator.

This change is being made because the Refreshing output isn't important
and it will make the comments shorter.
@lkysow lkysow force-pushed the remove-refreshing branch from 70128e4 to 16cdcf1 Compare October 30, 2018 21:28
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #339 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   70.63%   70.67%   +0.03%     
==========================================
  Files          61       61              
  Lines        3651     3655       +4     
==========================================
+ Hits         2579     2583       +4     
  Misses        893      893              
  Partials      179      179
Impacted Files Coverage Δ
server/events/markdown_renderer.go 92.59% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af4d79...16cdcf1. Read the comment docs.

@lkysow lkysow merged commit 3b91492 into master Oct 30, 2018
@lkysow lkysow deleted the remove-refreshing branch October 30, 2018 21:34
@majormoses
Copy link
Contributor

this will reduce a lot of headaches I have where developers are confused by the broken formatting and end up pinging me because they are not sure what to do. I have staged the changes and should be able to deploy tomorrow.

@majormoses
Copy link
Contributor

Verified today that it works beautifully it prevented the splitting across comments on states where I know it has previously. We should probably still find a solution for it but it becomes a lot less urgent as you would need to do a lot of changes for it to show up and in those cases you can just make smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants