Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo config #317

Closed
wants to merge 4 commits into from
Closed

Conversation

osterman
Copy link

what

  • Import PR by @darrylb-github
  • Support multiple atlantis build manifests per repo

why

  • Allows setting different configs for different instances of atlantis, which is useful when wanting to run different servers for production and staging.

use-case

Have separate production and staging Atlantis servers. This enables that by using multiple atlantis.yaml config files in the same repo and setting the --repo-config flag on each server. This allows you to launch a staging Atlantis server pointing at a staging atlantis.yaml file (e.g. --repo-config atlantis-staging.yaml) and a production Atlantis server pointing at a production atlantis.yaml file in the same repo (e.g. --repo-config atlantis-production.yaml).

This way you can use different credentials for staging and production and maintain cleaner separation between environments.

why

  • Allow a given atlantis server to watch a specific manifest
  • Better multi-account strategy

references

…atlantis.yaml config file to use. This means multiple Atlantis servers can point at the same repo (e.g. for prod and staging).
@osterman osterman closed this Oct 13, 2018
@osterman
Copy link
Author

This was opened by mistake. Intended PR cloudposse-archives#8

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #317 into master will increase coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   70.54%   70.58%   +0.04%     
==========================================
  Files          61       61              
  Lines        3639     3644       +5     
==========================================
+ Hits         2567     2572       +5     
  Misses        893      893              
  Partials      179      179
Impacted Files Coverage Δ
cmd/server.go 79.59% <100%> (+0.57%) ⬆️
server/events/yaml/parser_validator.go 98.48% <100%> (ø) ⬆️
server/events/comment_parser.go 98.27% <100%> (ø) ⬆️
server/server.go 62.44% <100%> (+0.15%) ⬆️
server/events/project_command_builder.go 82.9% <84.61%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f174bf8...0c551c3. Read the comment docs.

@aknysh aknysh deleted the repo-config branch October 17, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants