feat(gitlab): add previous command comment deletion #2996
Conversation
| # or | ||
| ATLANTIS_DELETE_PREV_COMMAND_COMMENTS | ||
| ``` | ||
| Deletes previous command comments to declutter the merge request. This is only supported in Gitlab currently. Github users should use `--hide-prev-plan-comments`. |
There was a problem hiding this comment.
Maybe we should add this functionality under hide-prev-plan-comments flag? since this is basically the same thing but for gitlab.
There was a problem hiding this comment.
@jamengual I had had initially put it there, but over thought it and didn't want to hide a Delete command behind a Hide flag was my reasoning. :)
There was a problem hiding this comment.
Yes i think we should keep consistency with how we have it with github. It would be better to hide than to delete in order to keep auditability.
There was a problem hiding this comment.
Yeah I wish Gitlab supported hiding, however, there is a Discussion feature on gitlab that supports user minimization.
I was toying around with the idea of for every command sent by the user turn that merge request comment to a discussion and then have atlantis reply to that discussion.
This idea was born when tons of big plans/applys would slow the UI down significantly.
I agree with the auditability of it. I was also considering keeping the last 3 or remove the last plans on successful apply.
I'd love to hear thoughts and feedback for sure! I appreciate the comments up to this point.
There was a problem hiding this comment.
Oh i like this idea! Let me investigate it Id be happy to implement if its possible! I'll look into this thanks for the discussion @nitrocode
There was a problem hiding this comment.
Or how about update old plan with detail tag to hide it and create new comment?
There was a problem hiding this comment.
@tyler-allen-tango friendly ping
There was a problem hiding this comment.
Slating some time today to look and experiment with this. I'll update when I know more. @nitrocode Would you want to close this MR until i can try to test with some of the recommendations above such as details tag on the html markup/attempting to move the outputs to a diff location in gitlab. Will probably take a little bit.
There was a problem hiding this comment.
Completely up to you. I do not mind (1) keeping this open, (2) re-using this one with the recommendations above, or (3) closing and having a separate PR to solve the same problem.
Thanks for looking deeper into this
nitrocode
changed the title
github-actions
bot
added
docs
|
I am so sorry for the late reply. Let me review and I’ll update
accordingly.
On Wed, Feb 22, 2023 at 5:23 PM nitrocode ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In runatlantis.io/docs/server-configuration.md
<#2996 (comment)>
:
> @@ -607,6 +607,14 @@ and set `--autoplan-modules` to `false`.
Hide previous plan comments to declutter PRs. This is only supported in
GitHub currently. This is not enabled by default.
+### `--delete-prev-command-comments`
+ ```bash
+ atlantis server --delete-prev-command-comments
+ # or
+ ATLANTIS_DELETE_PREV_COMMAND_COMMENTS
+ ```
+ Deletes previous command comments to declutter the merge request. This is only supported in Gitlab currently. Github users should use `--hide-prev-plan-comments`.
@tyler-allen-tango <https://github.com/tyler-allen-tango> friendly ping
—
Reply to this email directly, view it on GitHub
<#2996 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4PG4JLCZWFN5HEHCLXYJETWY2NW7ANCNFSM6AAAAAAT6KD64E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
TC Tyler Allen
Sr DevOps Engineer
–––––––––––––––––––––––––––––––––––––––––
|
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
|
This interesting fro my org, i would like to potentially take over this feature. wdyt @nitrocode ? |
|
you can take it over, no problem. |
what
why
tests
references